New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow downloading lyrics locally #30

Closed

BreakTos wants to merge 1 commit into teccheck:master from BreakTos:master

BreakTos commented Feb 12, 2024 •

edited

Loading

The option to download is made available at both fastLyrics and viewLyrics fragment. Attaching the screenshots for same

Closes #5


          Allow downloading lyrics locally

784015e

Owner

teccheck commented Feb 12, 2024 •

edited

Loading

Thank you very much for the pull request. I've tested the code on my phone running Android 13 (SDK 31) and it didn't work. It seems like the method you've implemented is deprecated since SDK 31 and doesn't work. There is another way of doing that which you can read about here.

I'm really sorry, but I can't accept that implementation because of that. However I'd like to help you implement the new approach, if you don't mind

Author

BreakTos commented Feb 13, 2024

I see, i didn't test it on latest android devices.
Let me do it asap and update whatever needs to be changed

BreakTos closed this by deleting the head repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet