Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format code with prettier take 2 #728

Merged
merged 4 commits into from
Aug 23, 2024
Merged

Format code with prettier take 2 #728

merged 4 commits into from
Aug 23, 2024

Conversation

nimzco
Copy link
Member

@nimzco nimzco commented Aug 23, 2024

No description provided.

@nimzco
Copy link
Member Author

nimzco commented Aug 23, 2024

@JuanPabloDiaz I just ported your changes in this PR and it works!
I think when I had updated the settings the other day we haven't retried it!

@nimzco nimzco merged commit e2d3d32 into main Aug 23, 2024
@nimzco nimzco deleted the prettier-take-2 branch August 23, 2024 12:01
@nimzco nimzco mentioned this pull request Aug 23, 2024
Closed
nimzco added a commit that referenced this pull request Aug 23, 2024
@nimzco
Revert "Format code with prettier take 2 (#728)"
2f1f9ad 
This reverts commit e2d3d32.
@nimzco nimzco mentioned this pull request Aug 23, 2024
Merged
@JuanPabloDiaz
Copy link
Contributor

@JuanPabloDiaz I just ported your changes in this PR and it works! I think when I had updated the settings the other day we haven't retried it!

Cool! it looks great @nimzco!

nimzco added a commit that referenced this pull request Aug 23, 2024
@nimzco
Revert "Format code with prettier take 2 (#728)" (#729)
dff70e0
nimzco added a commit that referenced this pull request Aug 24, 2024
@nimzco
Revert "Revert "Format code with prettier take 2 (#728)" (#729)"
3318e7a 
This reverts commit dff70e0.
nimzco added a commit that referenced this pull request Aug 24, 2024
@nimzco
Revert "Revert "Format code with prettier take 2 (#728)" (#729)"
20a2bce 
This reverts commit dff70e0.
nimzco added a commit that referenced this pull request Aug 24, 2024
@nimzco
Revert "Revert "Format code with prettier take 2"" (#730)
fcde35a 
* Revert "Revert "Format code with prettier take 2 (#728)" (#729)"

This reverts commit dff70e0.

* change .prettierrc

* Add jsxSingleQuote to .prettierrc to align with eslint used in build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nimzco @JuanPabloDiaz