Merge pull request #14 from teeks99/literal-is-warning

Literal is warning
teeks99 · Oct 31, 2024 · dd4b466 · dd4b466
2 parents 2f121cb + 17a0a80
commit dd4b466
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/.github/workflows/package.yml b/.github/workflows/package.yml
@@ -7,14 +7,14 @@ jobs:
 
     steps:
     - name: checkout
-      uses: actions/checkout@v2
+      uses: actions/checkout@v4
     - name: get-hash
       id: hash
       run: echo "::set-output name=sha_short::$(git rev-parse --short HEAD)"     
     - name: run-build
       run: python3 build_package.py --set-version ${{ steps.hash.outputs.sha_short }}
     - name: artifact package
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       with:
         name: package
         path: dist/weewx-json_${{ steps.hash.outputs.sha_short }}.tar.gz
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,7 @@
 Upcoming
 --------
 
+*   Fixed a warning due to the use of `is` comparison with a literal instead of `==`
 
 1.2
 ---

diff --git a/skins/JSON/current_minimal.json.tmpl b/skins/JSON/current_minimal.json.tmpl
@@ -9,7 +9,7 @@
     },
     "generation":
     {
-        #if $Extras.timestamp_fmt is "human"
+        #if $Extras.timestamp_fmt == "human"
         "time": "$current.dateTime.format("%a, %d %b %Y %H:%M:%S %Z")",
         #else
         "time": "$current.dateTime.format("%Y-%m-%dT%H:%M:%S%z")",

diff --git a/skins/JSON/weewx.json.tmpl b/skins/JSON/weewx.json.tmpl
@@ -9,7 +9,7 @@
     },
     "generation":
     {
-        #if $Extras.timestamp_fmt is "human"
+        #if $Extras.timestamp_fmt == "human"
         "time": "$current.dateTime.format("%a, %d %b %Y %H:%M:%S %Z")",
         #else
         "time": "$current.dateTime.format("%Y-%m-%dT%H:%M:%S%z")",