Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Literal is warning #14

Merged
merged 4 commits into from
Oct 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@ jobs:

steps:
- name: checkout
uses: actions/checkout@v2
uses: actions/checkout@v4
- name: get-hash
id: hash
run: echo "::set-output name=sha_short::$(git rev-parse --short HEAD)"
- name: run-build
run: python3 build_package.py --set-version ${{ steps.hash.outputs.sha_short }}
- name: artifact package
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: package
path: dist/weewx-json_${{ steps.hash.outputs.sha_short }}.tar.gz
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
Upcoming
--------

* Fixed a warning due to the use of `is` comparison with a literal instead of `==`

1.2
---
Expand Down
2 changes: 1 addition & 1 deletion skins/JSON/current_minimal.json.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
},
"generation":
{
#if $Extras.timestamp_fmt is "human"
#if $Extras.timestamp_fmt == "human"
"time": "$current.dateTime.format("%a, %d %b %Y %H:%M:%S %Z")",
#else
"time": "$current.dateTime.format("%Y-%m-%dT%H:%M:%S%z")",
Expand Down
2 changes: 1 addition & 1 deletion skins/JSON/weewx.json.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
},
"generation":
{
#if $Extras.timestamp_fmt is "human"
#if $Extras.timestamp_fmt == "human"
"time": "$current.dateTime.format("%a, %d %b %Y %H:%M:%S %Z")",
#else
"time": "$current.dateTime.format("%Y-%m-%dT%H:%M:%S%z")",
Expand Down
Loading