Implement --dry for mrack plugin
#3460
Conversation
skycastlelily
requested review from
psss,
lukaszachy,
happz,
thrix,
janhavlin and
martinhoyer
as code owners
skycastlelily
added
the
ci | full test
tmt/steps/provision/mrack.py
Outdated
| mrack_requirement = self.api._mrack_transformer.create_host_requirement(data) | ||
| if self.is_dry_run: | ||
| job = self.api._mrack_provider._req_to_bkr_job(mrack_requirement) | ||
| self.info(f"beaker job xml: '{job.toxml()}'") |
There was a problem hiding this comment.
What about using self.print() here to print the job xml to stdout (not the introduction comment line) so that it can be easily consumed/parsed? Also, what about using pretty print (with indented content) to make it more human readable for users to review?
There was a problem hiding this comment.
That would make the XML output of tmt run provision -h beaker. Is it a debugging aid, or are we going to make a deliberate decision that this shall be (the only?) output of tmt run --dry-run? Just making sure it's a known effect :)
+1 for pretty-print, we absolutely want that.
There was a problem hiding this comment.
Is it a debugging aid, or are we going to make a deliberate decision that this shall be (the only?) output of tmt run --dry-run
I guess this is a deliberate decision that this shall be the output of tmt run --dry-run:)
Updated with self.print and pretty-print^^ : 6c540fa
skycastlelily
force-pushed
the
dry-mrack
branch
from
413e053 to
6c540fa
Compare
Pull Request Checklist