Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-Mint Text: #SwapOnTeia #367

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Conversation

merchantcoppola
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Dec 16, 2023

PR Preview Action v1.4.7
🚀 Deployed preview to https://teia-community.github.io/teia-ui/previews/pr-367/
on branch gh-pages at 2024-03-23 09:38 UTC

@melMass
Copy link
Member

melMass commented Jan 4, 2024

I just fear that might be noisy, maybe we could add a way to "don't show again"

@Zir0h
Copy link
Contributor

Zir0h commented Mar 3, 2024

I just fear that might be noisy, maybe we could add a way to "don't show again"

I'd rather have a bit too much noise in this case though 😅 it's like
everybody just mints on Teia and then immediately swaps on objkt.

And the message itself is really not much:
2024-03-03-181951_1567x438_scrot

@melMass
Copy link
Member

melMass commented Mar 5, 2024

And the message itself is really not much

I can't check properly right now but doesn't this PR add an extra message box after mint? I would merge the "Mint done" and this one if that's the case, otherwise ignore my message

@Zir0h
Copy link
Contributor

Zir0h commented Mar 5, 2024

And the message itself is really not much

I can't check properly right now but doesn't this PR add an extra message box after mint? I would merge the "Mint done" and this one if that's the case, otherwise ignore my message

It's the same box as before, just a different message

@melMass
Copy link
Member

melMass commented Mar 5, 2024

That's what I couldn't check earlier, I'm still not sure since this is main currently:

console.debug('success', success)
if (success) {
reset()
}

@Zir0h
Copy link
Contributor

Zir0h commented Mar 5, 2024

That's what I couldn't check earlier, I'm still not sure since this is main currently:

console.debug('success', success)
if (success) {
reset()
}

oh woops, didn't check that

@Zir0h
Copy link
Contributor

Zir0h commented Mar 5, 2024

ah yeah, look at merch's first commit: 2bd6561

@Zir0h
Copy link
Contributor

Zir0h commented Mar 23, 2024

I moved the message to prevent the double popup. There is however a little issue with my swap link. There's a small time frame between the tzkt indexer completion and the teia indexer completion. So the minter can get the "metadata being processed" if they click my swap link too soon. I don't think this is a big issue. It's possible to workaround this by also polling the teia indexer to check if the objkt is there, or maybe by adding a refresh on the "metadata being processed" page?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants