Skip to content

Commit

Permalink
Remove the gosec Makefile target.
Browse files Browse the repository at this point in the history
This is not managed by golangci-lint, which does it's own verisoning. The
version in golangci-lint likely won't match this version, so they're most likely
mismatched anyway.

Given that this Makefile target isn't used, we should drop it in favor of `make golangci-lint`
for consistency.

Signed-off-by: Dan Lorenc <lorenc.d@gmail.com>
  • Loading branch information
dlorenc authored and tekton-robot committed Sep 2, 2021
1 parent 7e52ce7 commit f041ef5
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ TESTPKGS = $(shell env GO111MODULE=on $(GO) list -f \
BIN = $(CURDIR)/.bin

GOLANGCI_VERSION = v1.42.0
GOSEC_VERSION = v2.4.0

GO = go
TIMEOUT_UNIT = 5m
Expand Down Expand Up @@ -171,14 +170,6 @@ $(BIN)/golangci-lint: ; $(info $(M) getting golangci-lint $(GOLANGCI_VERSION))
golangci-lint: | $(GOLANGCILINT) ; $(info $(M) running golangci-lint…) @ ## Run golangci-lint
$Q $(GOLANGCILINT) run --modules-download-mode=vendor --max-issues-per-linter=0 --max-same-issues=0 --deadline 5m

GOSEC = $(BIN)/gosec
$(BIN)/gosec: ; $(info $(M) getting gosec $(GOSEC_VERSION))
@curl -sfL https://raw.githubusercontent.com/securego/gosec/master/install.sh | sh -s -- -b $(BIN) $(GOSEC_VERSION)

.PHONY: gosec
gosec: | $(GOSEC) ; $(info $(M) running gosec…)
$Q $(GOSEC) ./...

GOIMPORTS = $(BIN)/goimports
$(BIN)/goimports: PACKAGE=golang.org/x/tools/cmd/goimports

Expand Down

0 comments on commit f041ef5

Please sign in to comment.