Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove the for-loop and use linux event watcher to monitor file… #8054

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Pangjiping
Copy link

@Pangjiping Pangjiping commented Jun 16, 2024

… change which could avoid a lot of CPU waste.

Changes

modify the behavior of detecting files through for-loop to use filesystem event watcher, which can avoid a lot of waste of CPU resources

/kind bug

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

… change which could avoid a lot of CPU waste.
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Jun 16, 2024
Copy link

linux-foundation-easycla bot commented Jun 16, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign vdemeester after the PR has been reviewed.
You can assign the PR to them by writing /assign @vdemeester in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot
Copy link
Collaborator

Hi @Pangjiping. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 16, 2024
@Pangjiping
Copy link
Author

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 16, 2024
@Pangjiping
Copy link
Author

related to issue #7293

In fact, we fully enabled sidecarlogresults in our large production environment (about 2 million taskruns per week), but after running for a period of time, we found a sharp increase in CPU usage. After troubleshooting, it was found that the implementation of sidecarlogresults had certain bug. I have fixed the problem and have been running safely in the production environment for three months. @jerop

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
internal/sidecarlogresults/sidecarlogresults.go 87.9% 82.2% -5.8

@chitrangpatel
Copy link
Contributor

related to issue #7293

In fact, we fully enabled sidecarlogresults in our large production environment (about 2 million taskruns per week), but after running for a period of time, we found a sharp increase in CPU usage. After troubleshooting, it was found that the implementation of sidecarlogresults had certain bug. I have fixed the problem and have been running safely in the production environment for three months. @jerop

That's amazing! Thanks for the fix. I'll review it promptly.

@chitrangpatel
Copy link
Contributor

related to issue #7293
In fact, we fully enabled sidecarlogresults in our large production environment (about 2 million taskruns per week), but after running for a period of time, we found a sharp increase in CPU usage. After troubleshooting, it was found that the implementation of sidecarlogresults had certain bug. I have fixed the problem and have been running safely in the production environment for three months. @jerop

That's amazing! Thanks for the fix. I'll review it promptly.

LGTM mostly. Any way we can bump the coverage? I see a significant portion of untested code. If we can do that via unit tests, that is great. If not, we should at least add some e2e tests.

@afrittoli
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 17, 2024
Comment on lines -3 to +5
go 1.18
go 1.21

toolchain go1.22.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change intended?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afrittoli it might not be, but it's doing the same thing automatically on my laptop (go 1.22.3 from nixos) — it automatically adds the toolchain entry.

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
internal/sidecarlogresults/sidecarlogresults.go 87.9% 82.2% -5.8

@tekton-robot
Copy link
Collaborator

@Pangjiping: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 18, 2024
@chitrangpatel chitrangpatel added this to the Pipeline v0.62 milestone Jul 8, 2024
@chitrangpatel
Copy link
Contributor

@Pangjiping I'm moving this to the next release milestone unless you have time to resolve the comments and merge conflicts soon. Please let us know.

@khrm
Copy link
Contributor

khrm commented Aug 27, 2024

/test pull-tekton-pipeline-build-tests

@tekton-robot
Copy link
Collaborator

@Pangjiping: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-tekton-pipeline-build-tests 490ac8a link true /test pull-tekton-pipeline-build-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tekton-robot
Copy link
Collaborator

The following Tekton test failed:

Test name Commit Details Required Rerun command
pull-tekton-pipeline-go-coverage-df 490ac8a link true /test pull-tekton-pipeline-go-coverage-df

Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you address review comments and fix linter issue due to which build is failing?

@afrittoli
Copy link
Member

@Pangjiping could you rebase this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants