[Waiting for tests] Allow deep Json attribute mapping by Stdr #1980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlvaroVega
changed the title
AlvaroVega
changed the title
fgalan
reviewed
Nov 20, 2020
| @@ -249,7 +249,7 @@ | |||
| + " \"newServicePath\": \"/new_default\"," | |||
There was a problem hiding this comment.
I see some little adaptations of existing test files, which I understand are not covering the new functionality.
Thus, maybe some additional test should be added to cover the new functionality?
There was a problem hiding this comment.
Then @joelcamus please, could you provide some tests to cover new functionality ?
AlvaroVega
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[cygnus-ngsi][NameMapping] Allow deep Json attribute mapping. #1856
Comes from #1979
Contributed from #1860
Take into account that namemapping has been improved since 1.8.3 and this code was designed for 1.8.3