Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation about websockets #2017

Merged
merged 5 commits into from
Apr 12, 2016

Conversation

fortizc
Copy link
Contributor

@fortizc fortizc commented Apr 10, 2016

Markdown documentation for websockets usage

"url": "/uri/used/to/this/operation",
"params": {"key": "value"},
"headers": {"key": "value"},
"payload" : {Put a normal REST message here}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of "Put a normal REST message here" I would suggest "Payload corresponding to the operation according to the REST API".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 63d6bf7

@fgalan
Copy link
Member

fgalan commented Apr 11, 2016

Apart of the documentation elements in this PR, please have a look to PR #1823 about building information.

}
}
```
A very important detail is the callback field, always must be "ws://" this say to Orion how notificacation must be send.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... callback field, which must always be exactly "ws://" - this tells Orion how notificacations are to be sent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 63d6bf7

{
"verb" : "POST",
"url" : "/v2/entities/E1",
"headers": {"Fiware-service": "my_Fiware-service"},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that - is not allowed in service paths (http://fiware-orion.readthedocs.org/en/develop/user/service_path/):

only alphanum and underscore allowed

I'd suggest to use my_service.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed ed74c6e

@fgalan
Copy link
Member

fgalan commented Apr 12, 2016

LGTM

1 similar comment
@kzangeli
Copy link
Member

LGTM

@kzangeli kzangeli merged commit 2841e13 into telefonicaid:feature/1181_websockets Apr 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants