Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config.js #678 #702

Closed

Conversation

MayankSingh-NEC
Copy link

Need to add some config for Scorpio Broker.
Also I've proposed some changes in node-lib repo for iotagent-json integration with Scorpio broker issue 1325.

@MayankSingh-NEC MayankSingh-NEC changed the title Update config.js Update config.js #678 Mar 22, 2023
@mapedraza
Copy link
Collaborator

The agents are Context Broker agnostics. No information given about the broker used, and adding information of multiples brokers (Orion, Orion-LD, Stelio or Scorpio) would add lot of noise to the agent config file. This specific port depends on each deployment, at leat in the Orion case, since you can deploy the broker in different ports, so we don't see adding this information is relevant for the user.

Additionally:

For all those reasons this PR should be closed

@mapedraza mapedraza closed this Mar 28, 2023
@MayankSingh-NEC
Copy link
Author

Hi @mapedraza , could we create separate documents

The agents are Context Broker agnostics. No information given about the broker used, and adding information of multiples brokers (Orion, Orion-LD, Stelio or Scorpio) would add lot of noise to the agent config file. This specific port depends on each deployment, at leat in the Orion case, since you can deploy the broker in different ports, so we don't see adding this information is relevant for the user.

Additionally:

For all those reasons this PR should be closed

Hi @mapedraza , just to acknowledge for the new user. Could we create a separate documents for the iotagents integration
with Scorpio CB and propose relevant changes in their config.

& I've raised this issue #1325, to give fix for iotagent integration with Scorpio boker using postgress db, Now it's working fine, but the fix I've proposed for,

Before fix:

  1. It always creates database with the lower case.
  2. Giving "fiware-service" -> "Robots" will create db with "Robots" but also it'll create separate db as "robots".
  3. This was conflicting earlier with the Scorpio CB. Gives as a result "Resource Not Found".
  4. Scorpio CB is case sensitive,

After fix:

  1. It will create with the same db whatever given in the "fiware-service".
  2. This will create only one db.
  3. No separate db are created.
  4. It is working fine with Scorpio CB and also for Iotagents (not case sensitives).

@fgalan
Copy link
Member

fgalan commented Apr 19, 2023

As explained at at https://thinking-cities.readthedocs.io/en/latest/multitenancy.html (*), regarding the service:

If uppercase characters are used, they are converted to lowercase.

What does the functionality you are changing in PR telefonicaid/iotagent-node-lib#1326 is exactly that, to convert the fiware-service to lowercase.

As I commented in another issue what NGSI-LD specification says about case sensitiveness in service ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants