Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] DTLS Implementation #122

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

m4n3dw0lf
Copy link

Described here: https://github.com/m4n3dw0lf/SecureFiware
Not shure if need some adjustments or something to merge in the master branch, any feedback will be appreciated, the config-secure.js is the configuration file used in the SecureFiware repository.

@@ -39,8 +39,8 @@
"cheerio": "0.20.0",
"xmldom": "0.1.22",
"logops": "1.0.0-alpha.7",
"iotagent-node-lib": "git://github.com/telefonicaid/iotagent-node-lib.git#master",
"lwm2m-node-lib": "git://github.com/telefonicaid/lwm2m-node-lib.git#master",
"iotagent-node-lib": "git://github.com/m4n3dw0lf/iotagent-node-lib.git#master",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the PR is finally approved, this should revert to its original value just before merging.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but the lwm2m-node-lib need to be merged with the DTLS Implementation..

@@ -39,6 +39,13 @@ function start() {
config = require('../config');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an entry in CHANGES_NEXT_RELEASE about the changes included in this PR, eg:

- Add: DTLS support (#xx)

where #xx is an issue number, if we have some one for DTLS implementation in this repository.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(y)

@fgalan
Copy link
Member

fgalan commented Apr 3, 2018

@m4n3dw0lf could this PR be considered final work? Or it stills in work-in-progresss status?

@m4n3dw0lf
Copy link
Author

m4n3dw0lf commented Apr 3, 2018

@fgalan , as a developer i will never have a final work, always will have something to improve hahaha, but.

This modifications in the iota is based in the features added in lwm2m-node-lib: telefonicaid/lwm2m-node-lib#127

Also will need to modify the config-secure.js to use the url instead of protocol as we discuss in telefonicaid/iotagent-node-lib#601

I will focus on the libs first, when the matter is resolved I will reformulate this PR to adapt to the modifications of the libraries, and also fix those checks that failed on the CI.

@chicco785
Copy link

given that this is pending finalisation of work on the lib, i would rename it as WIP

@m4n3dw0lf m4n3dw0lf changed the title DTLS Implementation [WIP] DTLS Implementation Apr 4, 2018
@fgalan
Copy link
Member

fgalan commented Jun 23, 2020

@m4n3dw0lf If this PR is still alive (long time since: "I will focus on the libs first, when the matter is resolved I will reformulate this PR to adapt to the modifications of the libraries, and also fix those checks that failed on the CI" :), please upgrade it with master branch and solve the file conflicts (probably due to the recent merge of PR #215)

Thanks!

CC: @jason-fox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants