Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Travis and add GitHub Actions. #89

Merged
merged 1 commit into from
Nov 25, 2020
Merged

Remove Travis and add GitHub Actions. #89

merged 1 commit into from
Nov 25, 2020

Conversation

jason-fox
Copy link
Contributor

@fgalan
Copy link
Member

fgalan commented Nov 24, 2020

Moving from Travis to git actions and increase the focus in Github for all development related tasks seems to be a good idea. However, I have one doubt (maybe due I'm a newbie with git actions :)

With travis a green or red mark appears near to the commit (and at the end, near the merge button) to show the result of the CI in the PR. However, with git actions I don't see anything similar:

imagen

Where the OK/NOK information appears now?

@fgalan
Copy link
Member

fgalan commented Nov 24, 2020

Where the OK/NOK information appears now?

It seem I was looking the wrong PR. I see the answer here telefonicaid/iotagent-ul#452 (comment). Sorry the noise...

Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit 14d26d5 into telefonicaid:master Nov 25, 2020
@fgalan
Copy link
Member

fgalan commented Nov 25, 2020

After merging this PR, it seems test are failing in master:

imagen

Note that before this PR, last commit in September was working:

imagen

@jason-fox does this make any sense to you? Maybe some dependence has change between September and now (not too much time... but maybe)?

@jason-fox
Copy link
Contributor Author

jason-fox commented Nov 25, 2020

You have three failing tests - I guess test/tools/mongoDBUtils.js is the place to look at.

 1) Device and configuration provisioning
       "before each" hook for "should fail with a 400 error":
     Error: Timeout of 3000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/runner/work/sigfox-iotagent/sigfox-iotagent/test/unit/deviceProvisioning-test.js)
  2) Context Broker communication
       "before each" hook for "should answer with a 200 OK":
     Uncaught TypeError: db.dropDatabase is not a function
      at /home/runner/work/sigfox-iotagent/sigfox-iotagent/test/tools/mongoDBUtils.js:34:20
      at /home/runner/work/sigfox-iotagent/sigfox-iotagent/node_modules/mongodb/lib/utils.js:731:5
  3) Plugin configuration test
       "before each" hook for "should use the plugin to parse the device responses":
     Uncaught TypeError: db.dropDatabase is not a function
      at /home/runner/work/sigfox-iotagent/sigfox-iotagent/test/tools/mongoDBUtils.js:34:20
      at /home/runner/work/sigfox-iotagent/sigfox-iotagent/node_modules/mongodb/lib/utils.js:731:5

The timeout may be related to these two, or may just need to be increased in the package.json

@fgalan
Copy link
Member

fgalan commented Nov 25, 2020

I understand that the failing tests were finally fixed by PR #90 . Now master shows good health.

imagen

Thanks!

@jason-fox jason-fox deleted the feature/github-actions branch November 25, 2020 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants