Acs aem commons 5.1.2 #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f051690.
…supportedOperationException (Adobe-Consulting-Services#2367) * Adobe-Consulting-Services#2366 CQIncludePropertyNamespaceServlet - UnsupportedOperationException, added test
…#2355) * ACS AEM Commons Console POC
* Added MS Office Addin components and content Co-authored-by: Chris Workman <chrisw@ensemble.com> Co-authored-by: Athiers <65783388+Athiers@users.noreply.github.com>
* fixed SCR warnings
* no need to catch exceptions in unittests, junit does that for us * fix warnings on some test executions * fix some more Mockito warnings * cleanup compilation warnings in test classes * removed unused MockPageManager, use the PageManager impl of AEM Mocks instead * fix more deprecation warnings * fix codeclimate issue * added changelog
* [trivial] fix exception message
* Adding a feature to the sitemap to not use the vanity when generating the URL * avoid too many negations, makes it easier to reason about it Co-authored-by: Jörg Hoh <joerg@joerghoh.de>
* Fix compilation warnings * suppress deprecation warnings because we cannot fix them right now or with the current implementation * use the static method valueOf instead of the constructors of the wrapped primitive types (Java9) * replace type.newInstance() with the recommended version (Java9) Co-authored-by: Brendan Robert <brendan.robert@gmail.com>
…ing-Services#2379) * - Fixed issue where sling model injection by @ChildResourceFromRequestInjector was not including all sling model bindings, thus resulting in models being injected with incorrect values for thing like currentStyle Co-authored-by: lokeshvajrala <41201017+lokeshvajrala@users.noreply.github.com> Co-authored-by: Lokesh Vajrala <lokesh.vajrala@infielddigital.com>
…ms (Adobe-Consulting-Services#2384) * Check for missing resource instead of freaking out and causing problems
…g Folder Titles (Adobe-Consulting-Services#2387) * Added option to not overwrite the destination folder title when creating the folder hierarchy. * Added tests.
Adobe-Consulting-Services#2382) * For some reason, handling the sling.filter.resourceTypes check on the properties causes issues. For now moving it into the doFilter itself, this resolves the problem. * ScrMetadataIT for IncludeDecoratorFilterImpl Co-authored-by: Niek Raaijmakers <niek@adobe.com> Co-authored-by: David Gonzalez <davidjgonzalez@gmail.com>
….amended-acs-commons.xml Removed extra comma (thanks Roger b!)
Adobe-Consulting-Services#2421) jjwt has been split into api and impl, and need them both Co-authored-by: Konrad Windszus <konrad.windszus@netcentric.biz>
…rvice (Adobe-Consulting-Services#2419) This fixes Adobe-Consulting-Services#2416 Co-authored-by: leonardoderks <EXTERN.DERKS_DIAZLEONARDODAVID@allianz.de> Co-authored-by: Konrad Windszus <konrad.windszus@netcentric.biz>
…er (Adobe-Consulting-Services#2415) domain optional Always close the XML stream writer. This fixes Adobe-Consulting-Services#2414 Co-authored-by: david g <davidjgonzalez@users.noreply.github.com>
) Make externalizer.domain optional Allow to give relative sitemap page paths Fix potential memory leak This fixes Adobe-Consulting-Services#2411 Co-authored-by: david g <davidjgonzalez@users.noreply.github.com>
…-commons into feature/localize-generic-lists
…dobe-Consulting-Services#2700) get rid of PowerMock due to incompatibility with Java 16+ use Azul Zulu JDKs for CI build use new Groovy plugin This closes Adobe-Consulting-Services#2754, Adobe-Consulting-Services#2753, Adobe-Consulting-Services#2754 Co-authored-by: david g <davidjgonzalez@users.noreply.github.com>
…-Consulting-Services#2759) If we don't list individuals the info from the organization is enough.
…be-Consulting-Services#2771) * re Adobe-Consulting-Services#2760 remove CloseableQuery from API * code climate fixes * add tests for QueryHelperImpl * add test for QueryBuilderViewQuery * resolves Adobe-Consulting-Services#2772 various blocker critical code scan issues
…ces#2761) * Switch from m-scr-p and m-bundle-p to bnd-m-p This closes Adobe-Consulting-Services#1718 Still WIP * use annotation for BundleActivator make ScrMetadataIT more robust by not relying on order in JAR ease debugging by prefixing property values coming from metatype with "(metatype)" * make Windows build work by using path which is understood by bnd https://bnd.bndtools.org/chapters/820-instructions.html#file * fix comments and reorder bnd instructions * reorder and clean up bnd instructions Co-authored-by: david g <davidjgonzalez@users.noreply.github.com>
use official option for inherited ds annotations
…-commons into master
This reverts commit 86b874d.
[maven-release-plugin] copy for tag acs-aem-commons-5.1.2 # Conflicts: # bundle-twitter/pom.xml # bundle/pom.xml # bundle/src/main/java/com/adobe/acs/commons/images/impl/NamedTransformImageServlet.java # bundle/src/main/java/com/adobe/acs/commons/images/package-info.java # bundle/src/test/java/com/adobe/acs/commons/images/impl/NamedTransformImageServletTest.java # content/pom.xml # pom.xml
jpsoaresx
requested review from
mehtarachna,
james-appleby,
tmgannagray and
suganya-thangavelu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebasing ACS commons to 5.1.2