-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adaptive Toolbar #5266
Merged
Merged
Adaptive Toolbar #5266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeyaVes
force-pushed
the
toolbar-adaptive
branch
8 times, most recently
from
December 12, 2024 15:10
dd91709
to
57a573d
Compare
TeyaVes
force-pushed
the
toolbar-adaptive
branch
from
December 13, 2024 13:12
318f4d7
to
be5d90a
Compare
epetrow
requested changes
Dec 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two additional things that I am wondering:
- Is overflow
true
by default since it does look like it from the tests? - Should we split the
toolbar-section
tests into two since we are showing sizing and fill mode in one?
TeyaVes
force-pushed
the
toolbar-adaptive
branch
2 times, most recently
from
December 16, 2024 13:53
a581ee0
to
a84b32e
Compare
|
zhpenkov
reviewed
Dec 16, 2024
TeyaVes
force-pushed
the
toolbar-adaptive
branch
5 times, most recently
from
December 18, 2024 13:03
58134b0
to
cc70997
Compare
TeyaVes
force-pushed
the
toolbar-adaptive
branch
from
December 18, 2024 13:52
c559b66
to
70b4e04
Compare
epetrow
requested changes
Dec 18, 2024
TeyaVes
force-pushed
the
toolbar-adaptive
branch
from
December 19, 2024 07:03
264e1d6
to
45547b2
Compare
TeyaVes
force-pushed
the
toolbar-adaptive
branch
4 times, most recently
from
December 19, 2024 11:28
f098726
to
c2be49e
Compare
The visual changes in the grid-angular tests are expected as previosly, the toolbar inside the grid didn't have a sizing class and no padding were applied, which is not correct. |
epetrow
approved these changes
Dec 19, 2024
TeyaVes
force-pushed
the
toolbar-adaptive
branch
from
December 19, 2024 14:05
aa9bf24
to
df70d87
Compare
zhpenkov
reviewed
Dec 19, 2024
TeyaVes
force-pushed
the
toolbar-adaptive
branch
from
December 20, 2024 08:56
92e1e48
to
680a96e
Compare
zhpenkov
approved these changes
Dec 20, 2024
inikolova
reviewed
Dec 20, 2024
packages/html/src/toolbar/templates/toolbar-scrollable-buttons-hidden.tsx
Outdated
Show resolved
Hide resolved
TeyaVes
force-pushed
the
toolbar-adaptive
branch
from
December 20, 2024 12:50
6c65beb
to
72a28bf
Compare
inikolova
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
targets: https://github.com/telerik/kendo-themes-private/issues/299
Toolbar Rendering Details
Scrolling Toolbar
k-toolbar-scrollable
if scrolling is enabledk-toolbar-scrollable-overlay
only if we want to display the gradient overlay - this is in the case when the Toolbar is scrollable, there are enough items for scrolling and the scrollButtons are hiddenk-toolbar-items
wrapperDetails
k-toolbar-button-separator
k-toolbar-prev
andk-toolbar-next
classesk-toolbar-scroll-items
class tok-toolbar-items
element if we want to enable the native browser scroll. Otherwise, don’t add the class and handle the scrolling in the componentk-toolbar-scrolling-start
,k-toolbar-scrolling-end
- if we are at the beginning of the scrolling (at the very left) or at the end. This takes care of the gradient overlay when the toolbar is scrollable but the buttons are not visible.Overflow section
k-toolbar-items-list
k-toolbar-items-list
-k-toolbar-items-list-solid, -flat, -outline; k-toolbar-items-list-sm, -md, -lg
depending on the Toolbar component optionsGlobal changes:
k-toolbar-separator
to the separatorsk-toolbar-button-separator
Details