Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Z' to tx timestamps to tell client that it's UTC #790

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

kylanhurt
Copy link
Contributor

Fixes #707

Description

  • TX timestamp showing incorrect because block timestamps do not have the 'Z' indicating the UTC time zone. They are not ISO-compliant 👎 but since they always do not have the 'Z' then we can just manually add it

Test scenarios

Time now matches the timestamp on the homepage

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage

@netlify
Copy link

netlify bot commented Oct 19, 2023

Deploy Preview for obe-testnet ready!

Name Link
🔨 Latest commit 332798f
🔍 Latest deploy log https://app.netlify.com/sites/obe-testnet/deploys/6531783ed513ed00083c1a4d
😎 Deploy Preview https://deploy-preview-790--obe-testnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 19, 2023

Deploy Preview for obe-staging ready!

Name Link
🔨 Latest commit 332798f
🔍 Latest deploy log https://app.netlify.com/sites/obe-staging/deploys/6531783ea5df0f00083ac5ca
😎 Deploy Preview https://deploy-preview-790--obe-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@donnyquixotic donnyquixotic merged commit 53ed0a0 into develop Oct 19, 2023
15 checks passed
@donnyquixotic donnyquixotic deleted the 707-timestamp-inconsistency branch October 19, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants