NAUM-6 Add v2::ToFraction #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also gets rid of lazy_static as a dev dep.
...instead of twice (once for numerators, once for denominators).
...and implement it for Unit.
turboladen
requested review from
tindron,
kurtronshausen,
robertpbaxter and
reeverseg
tindron
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what I think I'd like to use to replace the existing AsFraction trait, which is problematic (see the related ticket). I
v2feature flagv2::convertmodulev2::convert::ToFractiontraitUnitandMeasurement(there was noAsFractiontrait forMeasurementbefore)AsFraction::as_fraction()implementation to only iterate through all nestedTerms once (to collect numerators and denominators along the way) instead of iterating once for numerators and once for denominators.lazy_staticas a dep (was only used in 2 sets of tests)