Add python support #121
Add python support #121
Conversation
bogdancondorachi
force-pushed
the
python-language
branch
4 times, most recently
from
6d0ed00
to
235b150
Compare
| public function __construct(private array $keywords = [ | ||
| 'and', 'as', 'assert', 'async', 'await', 'break', 'class', 'continue', | ||
| 'def', 'del', 'elif', 'else', 'except', 'finally', 'for', 'from', 'global', | ||
| 'if', 'import', 'in', 'is', 'lambda', 'nonlocal', 'not', 'or', 'pass', | ||
| 'raise', 'return', 'try', 'while', 'with', 'yield', | ||
| ]) | ||
| { | ||
| } |
There was a problem hiding this comment.
Here I chose to add the keywords as an array directly within the class constructor for simplicity. For me this offers more efficiency and clarity, especially considering that the list of keywords is unlikely to change frequently.
| public function __construct(private array $builtinFunctions = [ | ||
| '__import__', 'abs', 'aiter', 'all', 'any', 'anext', 'ascii', 'bin', 'bool', | ||
| 'breakpoint', 'bytearray', 'bytes', 'callable', 'chr', 'classmethod', 'compile', | ||
| 'complex', 'delattr', 'dict', 'dir', 'divmod', 'enumerate', 'eval', 'exec', | ||
| 'filter', 'float', 'format', 'frozenset', 'getattr', 'globals', 'hasattr', | ||
| 'hash', 'help', 'hex', 'id', 'input', 'int', 'isinstance', 'issubclass', 'iter', | ||
| 'len', 'list', 'locals', 'map', 'max', 'memoryview', 'min', 'next', 'object', | ||
| 'oct', 'open', 'ord', 'pow', 'print', 'property', 'range', 'repr', 'reversed', | ||
| 'round', 'set', 'setattr', 'slice', 'sorted', 'staticmethod', 'str', 'sum', | ||
| 'super', 'tuple', 'type', 'vars', 'zip', | ||
| ]) | ||
| { | ||
| } |
There was a problem hiding this comment.
Same goes for the built-in functions, adding all of this individually inside the PythonLanguage just gave me anxiety 😂
bogdancondorachi
force-pushed
the
python-language
branch
2 times, most recently
from
14bd226
to
9f53a1e
Compare
bogdancondorachi
force-pushed
the
python-language
branch
from
9f53a1e
to
116da0e
Compare
Pull Request Test Coverage Report for Build 9206970052Details
💛 - Coveralls |
|
Ok @brendt, I will flag this as ready for review. I think it covers well most of the basic stuff to be considered usable. I'll defiantly continue into more edge cases and additional patterns but for now I'll leave that for a later update. |
|
Cool!
I agree, this can be finetuned later :) Are you on discord, by any chance? We have a server for Tempest related stuff, it would be nice if I could ping you there — I don't expect you to put in any work you don't want to, but I lack Python knowledge, so it'd be nice to bounce ideas off of someone if we need to further work on this: https://discord.gg/pPhpTGUMPQ Also, shall I wait until #123 gets merged and you can update this PR accordingly? |
|
FYI #123 has been merged :) |
bogdancondorachi
force-pushed
the
python-language
branch
from
b8b2947
to
b9f1393
Compare
bogdancondorachi
force-pushed
the
python-language
branch
from
b9f1393
to
dbde1c2
Compare
|
@brendt Added NUMBER and BOOLEAN support. This can be merged now. I'll continue to improve on it when I find time but for now, it should cover enough to be usable. |
@brendt As the title suggests this PR adds Python language support :)
📋 TODO: