Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update strings for PHP and JavaScript #149

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

lemmon
Copy link
Contributor

@lemmon lemmon commented Sep 6, 2024

Strings quotes fixes and updates based on #137.

PHP + JavaScript

(for both single and double quoted strings)

  • strings matches with quotes
  • fixes strings containing escaped quotes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10734705768

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.019%

Totals Coverage Status
Change from base Build 10628941517: 0.0%
Covered Lines: 1559
Relevant Lines: 1676

💛 - Coveralls

@brendt brendt merged commit dc2e025 into tempestphp:main Oct 24, 2024
4 checks passed
@brendt
Copy link
Member

brendt commented Oct 24, 2024

Thanks! Sorry it took a while to merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants