feat: add missing terminal styles #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
innocenzi
force-pushed
the
feat/more-styles
branch
from
900f6ce
to
38cec0b
Compare
innocenzi
force-pushed
the
feat/more-styles
branch
from
38cec0b
to
3f792d4
Compare
|
Thanks, tagged: https://github.com/tempestphp/highlight/releases/tag/2.11.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds some missing styles. I specifically needed
dimwhen working on Tempest's console.This is a draft because currently, theNO_*cases conflict. For instance, the code to stop bold text and stop dim text is the same:22m. But a feature of string-backed enums is that they can't have the same value multiple times... not sure what to do here.EDIT: I sorted it out by sharing the code as
RESET_INTENSITY