fix(generation): simplify traits and method parameter attributes #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gturpin-dev
changed the title
ClassManipulator
innocenzi
changed the title
ClassManipulator
|
Nice! |
gturpin-dev
deleted the
fix/generation/class-manipulator-expanded-namespaces
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think I opened an issue about it.
But there was an issue where the
ClassManipulatordo not simplifies class traits when they are in another namespace of the current class.Same goes for class method parameter attributes.
This PR make those two things to be simplified.
It cleans the current
make:modelcommand generated stub file