Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: cleanup unit test coverage #781

Closed
wants to merge 2 commits into from
Closed

Conversation

aidan-casey
Copy link
Member

No description provided.

@aidan-casey aidan-casey marked this pull request as ready for review November 26, 2024 04:36
@coveralls
Copy link

coveralls commented Nov 26, 2024

Pull Request Test Coverage Report for Build 12023997738

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4886 unchanged lines in 353 files lost coverage.
  • Overall coverage decreased (-50.8%) to 28.595%

Files with Coverage Reduction New Missed Lines %
src/Tempest/Cache/src/Config/cache.config.php 1 0.0%
src/Tempest/Cache/src/IsCache.php 1 88.89%
src/Tempest/CommandBus/src/Config/commandBus.config.php 1 0.0%
src/Tempest/Auth/src/Config/auth.config.php 1 0.0%
src/Tempest/Console/src/Config/console.config.php 1 0.0%
src/Tempest/Console/src/Config/scheduler.config.php 1 0.0%
src/Tempest/Console/src/Exceptions/ConsoleException.php 1 0.0%
src/Tempest/Database/src/Builder/TableName.php 1 92.31%
src/Tempest/Debug/src/functions.php 1 0.0%
src/Tempest/Generation/src/SimplifiesClassNames.php 1 92.75%
Totals Coverage Status
Change from base Build 12021710761: -50.8%
Covered Lines: 2734
Relevant Lines: 9561

💛 - Coveralls

@aidan-casey
Copy link
Member Author

@brendt - I know you'll hate this PR, BUT I believe it is important to really know where our unit coverage is. 😛

@brendt
Copy link
Member

brendt commented Nov 26, 2024

😂

It's just a number though. The only thing I'm interested in is being sure that when something is changed, will a test break somewhere telling me about it. I really don't care whether that's a unit or integration test.

@brendt brendt closed this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants