Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WorkflowUpdateResultException #526

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

roxblnfk
Copy link
Collaborator

@roxblnfk roxblnfk commented Nov 13, 2024

What was changed

Added the WorkflowUpdateResultException, which is thrown by UpdateHandle->getResult() when a Workflow Update Request is stuck in the ADMITTED status. This situation can occur when the Workflow neither accepts nor rejects the Update due to:

  • No available workers
  • Workflow Task fails in the same tick

Why?

Developers need to distinguish between null as an actual result of a Workflow Update action and "no result."
Prior to this patch, the code used assert($result === null), which did not align with reality. Additionally, assertions are typically disabled in production environments.

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
php ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 0:27am

@Sushisource
Copy link
Member

@roxblnfk So I think we don't need to do this at all - in the other SDKs we just keep trying until we hit the timeout or are cancelled and we should mirror that behavior here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants