Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added default GraphQL query filter for OT assets list func #737

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Added default GraphQL query filter for OT assets list func #737

merged 1 commit into from
Nov 21, 2023

Conversation

aseemsavio
Copy link
Collaborator

@aseemsavio aseemsavio commented Nov 17, 2023 •
edited
Loading

Description

Added a default query filter for OT Assets List functionality.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • This was tested locally with a test OT instance.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@aseemsavio aseemsavio requested a review from a team November 17, 2023 10:52
@aseemsavio aseemsavio self-assigned this Nov 17, 2023
@aseemsavio
Copy link
Collaborator Author

Trying to see why readthedocs has failed (passes in local)...

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@aseemsavio aseemsavio merged commit 7d360e6 into master Nov 21, 2023
14 checks passed
@aseemsavio aseemsavio deleted the ot-assets-default-query-filter branch November 21, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveMcGrath SteveMcGrath SteveMcGrath approved these changes

Assignees

@aseemsavio aseemsavio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aseemsavio @SteveMcGrath