Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Read the Docs Issue #740

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Fixing Read the Docs Issue #740

merged 2 commits into from
Nov 21, 2023

Conversation

aseemsavio
Copy link
Collaborator

@aseemsavio aseemsavio commented Nov 20, 2023 •
edited
Loading

Description

This PR fixes the Read the docs build issue. Changes were made based on information from this wiki following the failures in new PRs.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

This needs to be tested in GitHub Actions

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@aseemsavio aseemsavio self-assigned this Nov 20, 2023
@aseemsavio aseemsavio requested a review from a team November 20, 2023 05:26
@aseemsavio aseemsavio changed the title snyk error fixed Fixing Read the Docs Issue Nov 20, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SteveMcGrath SteveMcGrath merged commit 2874372 into master Nov 21, 2023
14 checks passed
@SteveMcGrath SteveMcGrath deleted the ot-io-filters branch November 21, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveMcGrath SteveMcGrath SteveMcGrath approved these changes

Assignees

@aseemsavio aseemsavio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aseemsavio @SteveMcGrath