enhance uniqueGrantID method

tencentyun · Apr 12, 2024 · bdc31f6 · bdc31f6
1 parent d3cf830
commit bdc31f6
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/cos.go b/cos.go
@@ -627,13 +627,13 @@ func decodeACL(resp *Response, res *ACLXml) {
 }
 
 func uniqueGrantID(grantIDs []string) string {
-	res := []string{}
-	filter := make(map[string]int)
+	res := make([]string, 0, len(grantIDs))
+	filter := make(map[string]struct{})
 	for _, id := range grantIDs {
-		if filter[id] != 0 {
+		if _, ok := filter[id]; ok {
 			continue
 		}
-		filter[id] = 1
+		filter[id] = struct{}{}
 		res = append(res, id)
 	}
 	return strings.Join(res, ",")

diff --git a/cos_test.go b/cos_test.go
@@ -231,3 +231,11 @@ func Test_SwitchHost(t *testing.T) {
 	}
 
 }
+
+func TestUniqueGrantID(t *testing.T) {
+	ids := []string{"abc", "abc", "ab"}
+	actual := uniqueGrantID(ids)
+	if actual != "abc,ab" {
+		t.Errorf("expect uniqueIDs to be abc,ab, got %v", actual)
+	}
+}