Ad Caching and Loading Enhancements #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teogor
added
@priority-critical
@issue
@bug-fix
ads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses multiple issues and introduces enhancements to the ad caching and loading system. The key commits included are:
1. Fix Issue with Ads Not Reloading on Expiry Due to Incorrect Call
This commit resolves an issue where ads were not reloading upon expiry due to an incorrect call. It ensures that ads are now reloaded as expected, providing a seamless ad experience for users.
2. Add
loadTimeParameter to CacheAdModel Sealed ClassIn this commit, we have introduced a new parameter,
loadTime, to theCacheAdModelsealed class. This parameter offers crucial information about the ad's load time and enhances the data associated with cached ads.3. Rename
CacheAdModeltoCachedAdThe class
CacheAdModelhas been renamed toCachedAdfor improved naming conventions and code readability.These changes collectively improve the performance and maintainability of the ad caching and loading system.
How to Use
You can continue to use the ad caching system as before, with the added benefit of improved ad reloading upon expiry and a clearer class name (
CachedAd). Additionally, theloadTimeparameter inCachedAdprovides essential information about ad load times.Closes #162