Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Color Theme Picker Based on Dynamic Theming Support #185

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

teogor
Copy link
Owner

@teogor teogor commented Mar 5, 2024

This pull request introduces an improvement to the logic that determines when to display the color theme picker. Previously, the picker only showed when disableDynamicTheming was true.

Changes:

  • The condition for displaying the color theme picker has been expanded.
  • The picker will now be shown in the following scenarios:
    • supportsDynamicTheming() returns true (dynamic theming is supported) and disableDynamicTheming is true (dynamic theming is disabled).
    • supportsDynamicTheming() returns false (dynamic theming is not supported).

@teogor teogor added this to the 1.0.0-alpha05 milestone Mar 5, 2024
@teogor teogor merged commit 7b97ed1 into main Mar 5, 2024
5 checks passed
@zeobot zeobot bot deleted the bug-fix/dynamic-theme-picker-logic branch March 5, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

1 participant