Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor App Information Access with BuildProfiler #189

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

teogor
Copy link
Owner

@teogor teogor commented Apr 15, 2024

Deprecate and Remove AppMetadataManager

This pull request removes the deprecated AppMetadataManager class and encourages usage of the BuildProfiler class for accessing application metadata.

Background:

The AppMetadataManager class has been marked as deprecated in favor of the more robust BuildProfiler class. This pull request completes the deprecation process by removing the redundant class entirely.

Removal:

The entire AppMetadataManager.kt file containing the deprecated class has been removed from the codebase.

Alternative:

  • For accessing application metadata (version details, build information, etc.), leverage the BuildProfiler class.
  • LocalBuildProfiler.current provides methods to retrieve specific data points previously offered by AppMetadataManager.

Benefits:

  • Promotes code cleanliness by eliminating unused and deprecated code.
  • Encourages use of the recommended and actively maintained BuildProfiler class.
  • Improves code clarity and maintainability.

@teogor teogor added the @enhancement New feature or request label Apr 15, 2024
@teogor teogor added this to the 1.0.0-alpha05 milestone Apr 15, 2024
@teogor teogor self-assigned this Apr 15, 2024
@teogor teogor merged commit 433aef9 into main Apr 15, 2024
5 checks passed
@zeobot zeobot bot deleted the deprecated/remove-app-metadata branch April 15, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

1 participant