Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AGP & Kotlin version, use AndroidX, fix sample app, make stories progress view resizable, enable resizable gaps & rounded corners #12

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

joetimmins
Copy link

@joetimmins joetimmins commented Sep 25, 2020

This PR will update:

  • Android Gradle Plugin -> 4.0.1
  • Gradle -> 6.6
  • Kotlin -> 1.4.10
  • Android Support Library -> AndroidX
  • Sample app -> now uses library in project instead of 1.1.2

This PR fixes:

  • Sample app: No findViewById call to set up stories progress view, was causing the stories progress view to not appear
  • StoriesProgressView: Now respects layout_height, all child views are set to match_parent, allows library users to change height of progress bar

This PR adds:

In order to add the rounded corners, the progress bar views now have a MaterialShapeDrawable placed on them. This requires the Material Components dependency, which has been added to the library module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

round edges of progress how to modify spacing between progress view?
1 participant