feat: Added a possibility to allow private hosted zone usage (#250)

terraform-aws-modules · Feb 10, 2022 · 5a53f39 · 5a53f39
1 parent ef36521
commit 5a53f39
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 7 deletions.
diff --git a/README.md b/README.md
@@ -226,14 +226,14 @@ allow_github_webhooks        = true
 | Name | Version |
 |------|---------|
 | <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 0.13.1 |
-| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 3.45 |
+| <a name="requirement_aws"></a> [aws](#requirement\_aws) | ~> 3.45 |
 | <a name="requirement_random"></a> [random](#requirement\_random) | >= 2.0 |
 
 ## Providers
 
 | Name | Version |
 |------|---------|
-| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 3.45 |
+| <a name="provider_aws"></a> [aws](#provider\_aws) | ~> 3.45 |
 | <a name="provider_random"></a> [random](#provider\_random) | >= 2.0 |
 
 ## Modules
@@ -372,6 +372,7 @@ allow_github_webhooks        = true
 | <a name="input_public_subnets"></a> [public\_subnets](#input\_public\_subnets) | A list of public subnets inside the VPC | `list(string)` | `[]` | no |
 | <a name="input_readonly_root_filesystem"></a> [readonly\_root\_filesystem](#input\_readonly\_root\_filesystem) | Determines whether a container is given read-only access to its root filesystem. Due to how Terraform type casts booleans in json it is required to double quote this value | `bool` | `false` | no |
 | <a name="input_repository_credentials"></a> [repository\_credentials](#input\_repository\_credentials) | Container repository credentials; required when using a private repo.  This map currently supports a single key; "credentialsParameter", which should be the ARN of a Secrets Manager's secret holding the credentials | `map(string)` | `null` | no |
+| <a name="input_route53_private_zone"></a> [route53\_private\_zone](#input\_route53\_private\_zone) | Enable to use a private Route53 zone | `bool` | `false` | no |
 | <a name="input_route53_record_name"></a> [route53\_record\_name](#input\_route53\_record\_name) | Name of Route53 record to create ACM certificate in and main A-record. If null is specified, var.name is used instead. Provide empty string to point root domain name to ALB. | `string` | `null` | no |
 | <a name="input_route53_zone_name"></a> [route53\_zone\_name](#input\_route53\_zone\_name) | Route53 zone name to create ACM certificate in and main A-record, without trailing dot | `string` | `""` | no |
 | <a name="input_security_group_ids"></a> [security\_group\_ids](#input\_security\_group\_ids) | List of one or more security groups to be added to the load balancer | `list(string)` | `[]` | no |

diff --git a/examples/github-complete/README.md b/examples/github-complete/README.md
@@ -30,14 +30,14 @@ Go to https://eu-west-1.console.aws.amazon.com/ecs/home?region=eu-west-1#/settin
 | Name | Version |
 |------|---------|
 | <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 0.13.1 |
-| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 3.45 |
+| <a name="requirement_aws"></a> [aws](#requirement\_aws) | ~> 3.45 |
 | <a name="requirement_github"></a> [github](#requirement\_github) | >= 4.8 |
 
 ## Providers
 
 | Name | Version |
 |------|---------|
-| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 3.45 |
+| <a name="provider_aws"></a> [aws](#provider\_aws) | ~> 3.45 |
 
 ## Modules
 

diff --git a/examples/github-complete/versions.tf b/examples/github-complete/versions.tf
@@ -4,7 +4,7 @@ terraform {
   required_providers {
     aws = {
       source  = "hashicorp/aws"
-      version = ">= 3.45"
+      version = "~> 3.45"
     }
 
     github = {

diff --git a/main.tf b/main.tf
@@ -131,7 +131,7 @@ data "aws_route53_zone" "this" {
   count = var.create_route53_record ? 1 : 0
 
   name         = var.route53_zone_name
-  private_zone = false
+  private_zone = var.route53_private_zone
 }
 
 ################################################################################

diff --git a/variables.tf b/variables.tf
@@ -224,6 +224,12 @@ variable "route53_record_name" {
   default     = null
 }
 
+variable "route53_private_zone" {
+  description = "Enable to use a private Route53 zone"
+  type        = bool
+  default     = false
+}
+
 variable "create_route53_record" {
   description = "Whether to create Route53 record for Atlantis"
   type        = bool

diff --git a/versions.tf b/versions.tf
@@ -4,7 +4,7 @@ terraform {
   required_providers {
     aws = {
       source  = "hashicorp/aws"
-      version = ">= 3.45"
+      version = "~> 3.45"
     }
 
     random = {