fix: Separate db_instance_tags from merged tags sub-module input
#544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winthropgutmann-ef
changed the title
var.db_instance_tags from var.tags module input
bryantbiggs
changed the title
var.db_instance_tags from var.tags module inputdb_instance_tags from merged tags sub-module input
antonbabenko
pushed a commit
that referenced
this pull request
Mar 19, 2024
## [6.5.3](v6.5.2...v6.5.3) (2024-03-19) ### Bug Fixes * Separate `db_instance_tags` from merged `tags` sub-module input ([#544](#544)) ([89a5763](89a5763))
|
This PR is included in version 6.5.3 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR splits the two on input so that the
var.db_instance_tagsare only applied to the rds_db_instance, preserving the functionality that ifvar.tagsis defined, it will be merged withvar.db_instance_tagsMotivation and Context
This change is required because it incorrectly maps
var.db_instance_tagsto all resources associated with the module. This functionality is reserved for thevar.tagsinput.var.db_instance_profiledescribed as "Additional tags for the DB instance", only these tags should be associated with therds_db_instanceBreaking Changes
None - backwards compatible since
var.db_instance_tagsandvar.tagsare still merged onthis.db_instancewhen present.How Has This Been Tested?
I need to test these changes, we have an existing project that this might be applicable in.
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request