fix: remove watsonx mark as sensitive var

[kierramarie]

Description

Mark as sensitive var was add to Watsonx DA so has been removed from this da.

Release required?

• No release
• Patch release (x.x.X)
• Minor release (x.X.x)
• Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

For mergers

• Use a conventional commit message to set the release level. Follow the guidelines.
• Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
• Use the Squash and merge option.

[kierramarie]

/run pipeline

[brendankellyibm]

@kierramarie That variable is being used here too - https://github.com/terraform-ibm-modules/terraform-ibm-rag-sample-da/blob/main/modules/watson-machine-learning/main.tf#L56

That will need to be refactored before we can remove the variable

[kierramarie]

@ocofaigh what should be done here?

[ocofaigh]

@kierramarie please work with the codeowner @brendankellyibm to determine next steps

[brendankellyibm]

@kierramarie @ocofaigh can I get more of an understanding on this issue? I see that the watsonX SaaS DA has this flag now, but is that not for the default project created in that DA?

We're still creating a different WatsonX project in this DA, so does it not make sense to keep the option intact?

[ocofaigh]

@kierramarie please include the issue link with the details / requirements of this change

[kierramarie]

Here is the issue: terraform-ibm-modules/terraform-ibm-watsonx-saas-da#167

I was asked to remove the variable from the rag sample da in that issue.

[brendankellyibm]

@in-1911 @ocofaigh @kierramarie

I think we still need the variable itself, as we're creating a project that the user may want to keep sensitive. We can refactor the code in light of this variable - in fact it seems we're not using the configure_project module from the SaaS DA when it would be better to. Let me know if I'm wrong in any assumption here.

[in-1911]

I needed this settings for a project in our lab demo scenarios to pass SCC scan, if this is implemented / deployed in Watson SaaS DA now, we can remove the whole project provisioning from the Sample App Config DA.
The only concern is that from Watson SaaS DA the project name is "demo" and does not use prefix - but that would be a minor issue.