Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update C5G7 blueprints from reference #1789

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

AidanMcDonald
Copy link
Contributor

What is the change?

Update a few numbers in C5G7 blueprints to match the reference document.

These specs are from Table 2 on page 6 of the composition/dimensions reference at https://www.oecd-nea.org/upload/docs/application/pdf/2020-01/nsc-doc96-02-rev2.pdf:

  1. Boron density in the moderator is specified as 2.78e-5 rather than 2.87e-5
  2. Aluminum clad is composed of Al-27 rather than natural Aluminum
  3. Fission chamber/central guide tube is stated to contain moderator plus 1.0e-8 atom/(b cm) U-235 (above Table 2 on page 6).

Why is the change being made?

I happened to catch a couple minor transcription errors between the C5G7 blueprints in ARMI and the reference while running the C5G7 benchmark problem with the openmc plugin.


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science self-requested a review July 19, 2024 23:09
@john-science john-science added the enhancement New feature or request label Jul 19, 2024
@AidanMcDonald
Copy link
Contributor Author

Found another change: temperature is specified as 20C.

@john-science
Copy link
Member

Found another change: temperature is specified as 20C.

@AidanMcDonald Any updates for us?

@AidanMcDonald
Copy link
Contributor Author

@john-science I have been working to get the correct benchmark results and finally succeeded, but the case that replicates the benchmark results is sufficiently different (the benchmark problem blends the fuel and clad together) that I think we shouldn't update the tutorial case to match it. My plan is to have the simpler exact benchmark case live in the openmc plugin and have a separate entry point in the plugin to run this theoretically more accurate case. I will have everything cleaned up and pushed in the coming days.

TL;DR: No update yet, but soon.

@AidanMcDonald
Copy link
Contributor Author

I've gone over the reference with a fine-toothed comb and can't find the source of the 90% enrichment number quoted in the comment. I'm now inclined to believe it was just a reasonable assumption like the comment said. I have replaced the old comment with a new one quoting the source of the new number.

Copy link
Member

@john-science john-science left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

Thanks, @AidanMcDonald

Before I go ahead and merge this, one last check: Do you think it's ready for prime time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants