Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the setting "mpiTasksPerNode" back to armi and rename it #1964

Closed
wants to merge 15 commits into from

Conversation

mbk-tp
Copy link
Contributor

@mbk-tp mbk-tp commented Oct 21, 2024

What is the change?

Putting the setting mpiTasksPerNode back into armi with a new name nTasksPerNode.

Why is the change being made?

In a prior PR, the setting mpiTasksPerNode was moved to an internal cluster plugin. However some codes still expect this setting to be in the ARMI framework.


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@CLAassistant
Copy link

CLAassistant commented Oct 21, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ mbk-tp
✅ john-science
❌ Bharat Medasani


Bharat Medasani seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@john-science john-science self-requested a review October 21, 2024 18:38
@john-science john-science added enhancement New feature or request feature request Smaller user request and removed enhancement New feature or request labels Oct 21, 2024
@john-science john-science marked this pull request as draft October 21, 2024 22:09
@opotowsky
Copy link
Member

this is no longer needed

@opotowsky opotowsky closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Smaller user request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants