Allowing users to define flag names with digits #1966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-science
changed the title
onufer
reviewed
Oct 22, 2024
onufer
approved these changes
Oct 22, 2024
john-science
changed the title
drewj-tp
added a commit
that referenced
this pull request
Oct 23, 2024
…xial-linkage * origin/main: Loading some ARMI DBs without the App that created them (#1917) Revert "Revert "Updating cluster settings (#1958)" (#1965)" (#1969) Allowing users to define flag names with digits (#1966) Revert "Updating cluster settings (#1958)" (#1965) Updating cluster settings (#1958) Reducing warnings while building the docs (#1959) Moving anl-afci-177 test files to their own directory (#1957)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the change?
Historically, ARMI
Flagshave been all-caps and English Alphabet only:FUEL,DUCT``,FEED`, and so on. And if you added a numerical digit into the mix, it would be ignored (for various reasons).This PR makes it so if the user defines a parameter it will be treated as an exception to the "letters only" rule, and handled exactly as-is.
This is only meant to support "upper case letters and numbers though". This PR still does not support flag names with:
Why is the change being made?
This was a feature request made by downstream users.
Checklist
docfolder.pyproject.toml.