Merge pull request #730 from terrestris/docker-image-build-time

Fix build time for docker images
terrestris · Sep 4, 2023 · b1e0db3 · b1e0db3
2 parents c738807 + a32e910
commit b1e0db3
Show file tree

Hide file tree

Showing 9 changed files with 85 additions and 18 deletions.
diff --git a/.java-version b/.java-version
@@ -0,0 +1,2 @@
+17
+
diff --git a/.licenserc.yaml b/.licenserc.yaml
@@ -40,5 +40,6 @@ header:
     - '**/*.iml'
     - '.releaserc.json'
     - '.commitlintrc.json'
+    - '.java-version'
 
   comment: on-failure
diff --git a/pom.xml b/pom.xml
@@ -248,7 +248,7 @@
                 <jvmFlag>-Djava.security.egd=file:/dev/./urandom</jvmFlag>
                 <jvmFlag>-Djdk.serialSetFilterAfterRead=true</jvmFlag>
               </jvmFlags>
-              <creationTime>EPOCH</creationTime>
+              <creationTime>USE_CURRENT_TIMESTAMP</creationTime>
             </container>
 
           </configuration>

diff --git a/shogun-boot/pom.xml b/shogun-boot/pom.xml
@@ -176,11 +176,26 @@
         </executions>
       </plugin>
       <plugin>
-        <groupId>pl.project13.maven</groupId>
-        <artifactId>git-commit-id-plugin</artifactId>
+        <groupId>io.github.git-commit-id</groupId>
+        <artifactId>git-commit-id-maven-plugin</artifactId>
+        <version>5.0.0</version>
+        <executions>
+          <execution>
+            <id>get-the-git-infos</id>
+            <goals>
+              <goal>revision</goal>
+            </goals>
+            <phase>initialize</phase>
+          </execution>
+        </executions>
         <configuration>
-          <offline>true</offline>
-          <abbrevLength>8</abbrevLength>
+          <generateGitPropertiesFile>true</generateGitPropertiesFile>
+          <generateGitPropertiesFilename>${project.build.outputDirectory}/git.properties</generateGitPropertiesFilename>
+          <includeOnlyProperties>
+            <includeOnlyProperty>^git.build.(time|version)$</includeOnlyProperty>
+            <includeOnlyProperty>^git.commit.id.(abbrev|full)$</includeOnlyProperty>
+          </includeOnlyProperties>
+          <commitIdGenerationMode>full</commitIdGenerationMode>
         </configuration>
       </plugin>
       <plugin>

diff --git a/shogun-config/pom.xml b/shogun-config/pom.xml
@@ -30,8 +30,24 @@
   <name>SHOGun Config</name>
   <packaging>jar</packaging>
 
-  <dependencies>
+  <build>
+    <plugins>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-compiler-plugin</artifactId>
+      </plugin>
+      <plugin>
+        <groupId>com.google.cloud.tools</groupId>
+        <artifactId>jib-maven-plugin</artifactId>
+        <configuration>
+          <!-- we don't want jib to execute on this module -->
+          <skip>true</skip>
+        </configuration>
+      </plugin>
+    </plugins>
+  </build>
 
+  <dependencies>
     <!-- Spring Boot -->
     <dependency>
       <groupId>org.springframework.boot</groupId>

diff --git a/shogun-gs-interceptor/pom.xml b/shogun-gs-interceptor/pom.xml
@@ -144,14 +144,7 @@
           </execution>
         </executions>
       </plugin>
-      <plugin>
-        <groupId>pl.project13.maven</groupId>
-        <artifactId>git-commit-id-plugin</artifactId>
-        <configuration>
-          <offline>true</offline>
-          <abbrevLength>8</abbrevLength>
-        </configuration>
-      </plugin>
+
       <plugin>
         <groupId>com.google.cloud.tools</groupId>
         <artifactId>jib-maven-plugin</artifactId>

diff --git a/shogun-lib/pom.xml b/shogun-lib/pom.xml
@@ -36,6 +36,14 @@
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-compiler-plugin</artifactId>
       </plugin>
+      <plugin>
+        <groupId>com.google.cloud.tools</groupId>
+        <artifactId>jib-maven-plugin</artifactId>
+        <configuration>
+          <!-- we don't want jib to execute on this module -->
+          <skip>true</skip>
+        </configuration>
+      </plugin>
     </plugins>
   </build>
 

diff --git a/shogun-manager/pom.xml b/shogun-manager/pom.xml
@@ -28,6 +28,23 @@
   <name>SHOGun Manager client</name>
   <packaging>jar</packaging>
 
+  <build>
+    <plugins>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-compiler-plugin</artifactId>
+      </plugin>
+      <plugin>
+        <groupId>com.google.cloud.tools</groupId>
+        <artifactId>jib-maven-plugin</artifactId>
+        <configuration>
+          <!-- we don't want jib to execute on this module -->
+          <skip>true</skip>
+        </configuration>
+      </plugin>
+    </plugins>
+  </build>
+
   <dependencies>
     <dependency>
       <groupId>de.terrestris</groupId>

diff --git a/shogun-proxy/pom.xml b/shogun-proxy/pom.xml
@@ -123,11 +123,26 @@
         </executions>
       </plugin>
       <plugin>
-        <groupId>pl.project13.maven</groupId>
-        <artifactId>git-commit-id-plugin</artifactId>
+        <groupId>io.github.git-commit-id</groupId>
+        <artifactId>git-commit-id-maven-plugin</artifactId>
+        <version>5.0.0</version>
+        <executions>
+          <execution>
+            <id>get-the-git-infos</id>
+            <goals>
+              <goal>revision</goal>
+            </goals>
+            <phase>initialize</phase>
+          </execution>
+        </executions>
         <configuration>
-          <offline>true</offline>
-          <abbrevLength>8</abbrevLength>
+          <generateGitPropertiesFile>true</generateGitPropertiesFile>
+          <generateGitPropertiesFilename>${project.build.outputDirectory}/git.properties</generateGitPropertiesFilename>
+          <includeOnlyProperties>
+            <includeOnlyProperty>^git.build.(time|version)$</includeOnlyProperty>
+            <includeOnlyProperty>^git.commit.id.(abbrev|full)$</includeOnlyProperty>
+          </includeOnlyProperties>
+          <commitIdGenerationMode>full</commitIdGenerationMode>
         </configuration>
       </plugin>
       <plugin>