Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs and code smells identified by sonar #855

Merged
merged 3 commits into from
May 2, 2024
Merged

Fix bugs and code smells identified by sonar #855

merged 3 commits into from
May 2, 2024

Conversation

LukasLohoff
Copy link
Member

@LukasLohoff LukasLohoff commented May 2, 2024 •
edited
Loading

Description

  • apply transactional annotations consistently
  • remove duplicated class fields
  • fix some minor html issues

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Tests
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I understand and agree that the changes in this PR will be licensed under the
    Apache Licence Version 2.0.
  • I have followed the guidelines for contributing.
  • The proposed change fits to the content of the code of conduct.
  • I have added or updated tests and documentation, and the test suite passes (run mvn test locally).
  • I have added a screenshot/screencast to illustrate the visual output of my update.

@terrestris/devs Please review.

@LukasLohoff LukasLohoff marked this pull request as ready for review May 2, 2024 08:53
KaiVolland
KaiVolland approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@KaiVolland KaiVolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@LukasLohoff LukasLohoff merged commit 093edf3 into main May 2, 2024
4 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 2, 2024

🎉 This PR is included in version 19.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaiVolland KaiVolland KaiVolland approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LukasLohoff @KaiVolland