Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add printApp to DefaultApplicationClientConfig #862

Merged
merged 2 commits into from
May 15, 2024
Merged

feat: add printApp to DefaultApplicationClientConfig #862

merged 2 commits into from
May 15, 2024

Conversation

AmandaTamanda
Copy link
Contributor

@AmandaTamanda AmandaTamanda commented May 15, 2024 •
edited
Loading

Description

Adds printApp to default client config to give more possibilities of selecting print templates per app

Related issues or pull requests

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Tests
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I understand and agree that the changes in this PR will be licensed under the
    Apache Licence Version 2.0.
  • I have followed the guidelines for contributing.
  • The proposed change fits to the content of the code of conduct.
  • I have added or updated tests and documentation, and the test suite passes (run mvn test locally).
  • I have added a screenshot/screencast to illustrate the visual output of my update.

KaiVolland
KaiVolland approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@KaiVolland KaiVolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. But I'd adjust the description a bit.

...in/java/de/terrestris/shogun/lib/model/jsonb/application/DefaultApplicationClientConfig.java Outdated Show resolved Hide resolved
@AmandaTamanda @KaiVolland
Update shogun-lib/src/main/java/de/terrestris/shogun/lib/model/jsonb/…
f6c1745 
…application/DefaultApplicationClientConfig.java

Co-authored-by: Kai Volland <kaivolland@yahoo.de>
@AmandaTamanda
Copy link
Contributor Author

Nice. But I'd adjust the description a bit.

Thank you for the review, I have incorporated your suggestion.

@KaiVolland KaiVolland merged commit 83f8ecb into main May 15, 2024
3 of 4 checks passed
github-actions bot pushed a commit that referenced this pull request May 21, 2024
@semantic-release-bot
chore(release): 20.1.0 [skip ci]
406b6e3 
# [20.1.0](v20.0.0...v20.1.0) (2024-05-21)

### Bug Fixes

* prevent exception when keycloak group does not exist ([9fb7732](9fb7732))

### Features

* add printApp to DefaultApplicationClientConfig ([#862](#862)) ([83f8ecb](83f8ecb))
@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 20.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaiVolland KaiVolland KaiVolland approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AmandaTamanda @KaiVolland