Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix role permissions #876

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Fix role permissions #876

merged 2 commits into from
Jun 17, 2024

Conversation

dnlkoch
Copy link
Member

@dnlkoch dnlkoch commented Jun 14, 2024

Description

This is a follow up of #872 and fixes the behaviour for the newly added role mapping by checking against the roles of the shogun Keycloak client (usually shogun-boot) instead of a realm role.

It also removes the listener for the REALM_ROLE events. Replacing it with something like CLIENT_ROLE seems not possible right now since the corresponding event does not contain the id of the new role since it's not created yet.

Please review @terrestris/devs.

Related issues or pull requests

See #872.

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Tests
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I understand and agree that the changes in this PR will be licensed under the
    Apache Licence Version 2.0.
  • I have followed the guidelines for contributing.
  • The proposed change fits to the content of the code of conduct.
  • I have added or updated tests and documentation, and the test suite passes (run mvn test locally).
  • I have added a screenshot/screencast to illustrate the visual output of my update.

@dnlkoch
Copy link
Member Author

dnlkoch commented Jun 17, 2024

Thanks for the review!

@dnlkoch dnlkoch merged commit 4b09a23 into main Jun 17, 2024
4 checks passed
@dnlkoch dnlkoch deleted the fix-role-permissions branch June 17, 2024 07:51
Copy link
Contributor

🎉 This PR is included in version 20.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants