Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add wmtsDimensions parameter for layer source #916

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

simonseyock
Copy link
Member

Description

Adds the wmtsDimensions parameter to the layer source

Related issues or pull requests

terrestris/shogun-util#750

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Tests
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I understand and agree that the changes in this PR will be licensed under the
    Apache Licence Version 2.0.
  • I have followed the guidelines for contributing.
  • The proposed change fits to the content of the code of conduct.
  • I have added or updated tests and documentation, and the test suite passes (run mvn test locally).
  • I have added a screenshot/screencast to illustrate the visual output of my update.

description = "Dimension parameters to be replaced for WMTS requests",
example = "{\"Time\": \"2010\"}"
)
private HashMap<String, String> wmtsDimensions;
Copy link
Member Author

@simonseyock simonseyock Aug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For requestParams the type is HashMap<String, Object>. I suppose it is not a problem to use a more specific type here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically it shouldn't be a problem, but I assume users must pass a string value (in the admin client)? If so it might be confusing since it's possible for the requestParams.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants