Create a common config for collision checking #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Levi-Armstrong I'd like to get your thoughts on this and the comments in #427. |
|
@Levi-Armstrong Any idea offhand what is going on with descartes? |
|
Oh, I bet I have to cast some things to FloatType |
|
@Levi-Armstrong if this passes it is ready for review. I have not fully converted the planners to use it, but I think that might come after #443 |
mpowelson
force-pushed
the
feature/common_collsion
branch
from
56f7a88 to
789b5c4
Compare
.../include/tesseract_motion_planners/descartes/impl/profile/descartes_default_plan_profile.hpp
Outdated
Show resolved
Hide resolved
.../include/tesseract_motion_planners/descartes/impl/profile/descartes_default_plan_profile.hpp
Show resolved
Hide resolved
.../include/tesseract_motion_planners/descartes/impl/profile/descartes_default_plan_profile.hpp
Show resolved
Hide resolved
mpowelson
force-pushed
the
feature/common_collsion
branch
from
789b5c4 to
fcf981b
Compare
|
I just deleted Verbosity from tesseract_common and squashed everything |
mpowelson
force-pushed
the
feature/common_collsion
branch
from
fcf981b to
fd08265
Compare
|
Added the todos for the XML |
|
@Levi-Armstrong Ok with me merging? |
Levi-Armstrong
approved these changes
Nov 20, 2020
Sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will Address #427