Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor updates for LocalStackV2Container #270

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

greshny
Copy link
Contributor

@greshny greshny commented Jan 28, 2024

  • fixed deprecation warning
[warn] testcontainers-scala/modules/localstackV2/src/main/scala/com/dimafeng/testcontainers/LocalStackV2Container.scala:14:13: constructor LocalStackContainer in class LocalStackContainer is deprecated: see corresponding Javadoc for more information.
[warn]     val c = new JavaLocalStackContainer(tag)
[warn]             ^
[warn] one warning found
  • added basic unit test for LocalStackV2 container
  • changed a bit arguments signature in helper methods for dependencies
  • bump aws-toolkit v2 version

@dimafeng dimafeng merged commit 001a007 into testcontainers:master Jan 29, 2024
3 checks passed
@greshny greshny deleted the update-localstack-v2 branch January 29, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants