Add WireMock container wrapper #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build failed, but it doesn't seem to be related to the changes. |
arttsu
force-pushed
the
wiremock-support
branch
from
e4f5b7e
to
846c622
Compare
Merged
|
@arttsu could you please rebase to the latest master? |
arttsu
force-pushed
the
wiremock-support
branch
from
846c622
to
6c309ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, thanks a lot for your work on the lib!
This PR adds a wrapper for Java
WireMockContainerwith functionallity needed for our use-case. I'm not 100% sure about the approach for calling builder methods on the underlying container. If you think it's an OK approach, I will also add support for the rest of the builder methods and some documentation.