Fix NPE when receiving "external" diagnostics

Fix eclipse-jdtls#285
testforstephen · Apr 24, 2024 · 36482ef · 36482ef
1 parent 7f504f1
commit 36482ef
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/org.eclipse.jdt.core.javac/src/org/eclipse/jdt/core/dom/JavacCompilationUnitResolver.java b/org.eclipse.jdt.core.javac/src/org/eclipse/jdt/core/dom/JavacCompilationUnitResolver.java
@@ -231,7 +231,7 @@ private Optional<CompilationUnit> findTargetDOM(Map<JavaFileObject, CompilationU
 			return Optional.empty();
 		}
 		if (obj instanceof JavaFileObject o) {
-			return Optional.of(filesToUnits.get(o));
+			return Optional.ofNullable(filesToUnits.get(o));
 		}
 		if (obj instanceof DiagnosticSource source) {
 			return findTargetDOM(filesToUnits, source.getFile());