Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register Form Enhancement #141

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Register Form Enhancement #141

wants to merge 4 commits into from

Conversation

SangeethaTestPress
Copy link
Contributor

@SangeethaTestPress SangeethaTestPress commented Jul 10, 2020 •
edited
Loading

Changes done

  • Added Password visibility toggle to view the entered characters in the password and confirm password fields in the register form
  • Updated the username regex so that it can accept the username with special characters ( @/+/-/_/.)

Reason for the changes

  • Password visibility toggle is important so that user can see what they entered in the password field
  • Username with Special characters is needed so that user can easily get the unique username.

Guidelines

  • Have you self reviewed this PR in context to the previous PR feedbacks?

Karthik-0
Karthik-0 requested changes Jul 10, 2020
View reviewed changes
app/src/main/res/layout/register_activity.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/register_activity.xml Outdated Show resolved Hide resolved
@SangeethaTestPress SangeethaTestPress changed the title added eye icon for password in register activity Add password visibility toggler to register form Jul 10, 2020
@SangeethaTestPress SangeethaTestPress changed the title Add password visibility toggler to register form Register Form Enhancement Jul 13, 2020
@harinath01 harinath01 force-pushed the master branch 4 times, most recently from c686873 to f9b09e8 Compare May 10, 2022 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karthik-0 Karthik-0 Karthik-0 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SangeethaTestPress @Karthik-0