Convert java to kotlin #142
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karthik-0
requested changes
Jul 15, 2020
Comment on lines
+163
to
+183
| if (!populated(editTextPassword)) { | ||
| passwordErrorText.visibility = View.VISIBLE | ||
| passwordErrorText.text = getString(R.string.empty_input_error) | ||
| isValid = false | ||
| } | ||
| if (!populated(editTextConfirmPassword)) { | ||
| confirmPasswordErrorText.visibility = View.VISIBLE | ||
| confirmPasswordErrorText.text = getString(R.string.empty_input_error) | ||
| isValid = false | ||
| } | ||
| if (!populated(editTextEmail)) { | ||
| emailErrorText.visibility = View.VISIBLE | ||
| emailErrorText.text = getString(R.string.empty_input_error) | ||
| isValid = false | ||
| } | ||
| if (!populated(editTextUserName)) { | ||
| usernameErrorText.visibility = View.VISIBLE | ||
| usernameErrorText.text = getString(R.string.empty_input_error) | ||
| isValid = false | ||
| } | ||
|
|
There was a problem hiding this comment.
Duplicate code can be reduced by extraction
Comment on lines
+246
to
+248
| private fun populated(editText: EditText): Boolean { | ||
| return editText.text.toString().trim().isNotEmpty() | ||
| } |
There was a problem hiding this comment.
Can be used as extension
Comment on lines
+326
to
+334
| private fun showProgressDialog() { | ||
| progressDialog = MaterialDialog.Builder(this) | ||
| .title(R.string.loading) | ||
| .content(R.string.please_wait) | ||
| .widgetColorRes(R.color.primary) | ||
| .progress(true, 0) | ||
| .cancelable(false) | ||
| .show() | ||
| } |
Comment on lines
+390
to
+392
| intent?.extras?.let { | ||
| intent.putExtras(it) | ||
| } |
Comment on lines
+395
to
+420
| private fun showSuccessLayout() { | ||
| registerLayout.visibility = View.GONE | ||
| success_description.setText(R.string.activation_email_sent_message) | ||
| success_complete.visibility = View.VISIBLE | ||
| } | ||
|
|
||
| private fun setUserNameError(registrationErrorDetails: RegistrationErrorDetails) { | ||
| usernameErrorText.visibility = View.VISIBLE | ||
| usernameErrorText.text = registrationErrorDetails.username[0] | ||
| editTextUserName.requestFocus() | ||
| } | ||
|
|
||
| private fun setEmailError(registrationErrorDetails: RegistrationErrorDetails) { | ||
| emailErrorText.visibility = View.VISIBLE | ||
| emailErrorText.text = registrationErrorDetails.email[0] | ||
| editTextEmail.requestFocus() | ||
| } | ||
|
|
||
| private fun setPasswordError(registrationErrorDetails: RegistrationErrorDetails) { | ||
| passwordErrorText.visibility = View.VISIBLE | ||
| passwordErrorText.text = registrationErrorDetails.password[0] | ||
| editTextPassword.requestFocus() | ||
| } | ||
|
|
||
| private fun setPhoneNumberError(registrationErrorDetails: RegistrationErrorDetails) { | ||
| phoneErrorText.visibility = View.VISIBLE |
There was a problem hiding this comment.
Code duplications can be removed by extraction method
harinath01
force-pushed
the
master
branch
4 times, most recently
from
c686873
to
f9b09e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes done
Reason for the changes
Fixes # . Remove this line if there aren't any corresponding issues created
Stats
Guidelines