Fix nav drawer #145
Fix nav drawer #145
Conversation
| private void setupEasterEgg() { | ||
| Menu navigationMenu = navigationView.getMenu(); | ||
| initializeNavigationHeaderView(); |
There was a problem hiding this comment.
This is not right place to initializeNavigationHeaderView()
|
|
||
| class ProfileDetailsViewModel : ViewModel() { | ||
| private var profileDetails = MutableLiveData<ProfileDetails?>() | ||
| fun get(serviceProvider: TestpressServiceProvider, activity: Activity): LiveData<ProfileDetails?> { |
There was a problem hiding this comment.
Use NetworkBoundResource
There was a problem hiding this comment.
This is fetching from the network every time.
| android:layout_weight="1" | ||
| > |
|
|
||
| private void getProfileDetailsFromViewModel() { | ||
| if (isUserAuthenticated) { | ||
| profileDetailsViewModel.get(serviceProvider, this).observe(this, new Observer<ProfileDetails>() { |
There was a problem hiding this comment.
Don't need to pass serviceProvider. Create repository and inject it in constructor
| } | ||
|
|
||
| private void setProfileDetailsOnDrawer() { | ||
| if (profileDetails == null) { |
There was a problem hiding this comment.
Use Resource class to check if get is a success or error
| } else { | ||
| navigationHeader.setVisibility(View.VISIBLE); | ||
| username.setText(profileDetails.getDisplayName()); | ||
| getBitmapFromString(); |
| ImageLoader.getInstance().loadImage(profileDetails.getPhoto(), new SimpleImageLoadingListener() { | ||
| @Override | ||
| public void onLoadingFailed(String imageUri, View view, FailReason failReason) { | ||
| hideNavigationHeader(); |
There was a problem hiding this comment.
Do not hide the navigation header if image fetch is failed. Show placeholder instead.
| navigationHeader.setVisibility(View.VISIBLE); | ||
| username.setText(profileDetails.getDisplayName()); | ||
| getBitmapFromString(); | ||
| setOnClickListener(); |
There was a problem hiding this comment.
Call this method in onCreateView
| app:strokeWidth="1dp"> | ||
|
|
||
| <ImageView | ||
| android:id="@+id/img_profile" |
There was a problem hiding this comment.
| android:id="@+id/img_profile" | |
| android:id="@+id/profile_image" |
| <View | ||
| android:layout_width="match_parent" | ||
| android:layout_height="1dp" | ||
| android:layout_marginTop="25dp" | ||
| android:background="@color/grey_icon" /> |
There was a problem hiding this comment.
Use navigation menu's divider
harinath01
force-pushed
the
master
branch
4 times, most recently
from
c686873
to
f9b09e8
Compare
Changes done
-Added a viewmodel to get the profileDetails