Add a class to validate register form #158
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharathwaaj
requested changes
Oct 7, 2020
| return isValid | ||
| } | ||
|
|
||
| private fun checkAndSetEmptyError() { |
There was a problem hiding this comment.
This function is doing more than one thing. Also the name is not meaningful.
| package `in`.testpress.testpress.util | ||
|
|
||
| import `in`.testpress.testpress.authenticator.RegisterActivity.VerificationMethod | ||
| import `in`.testpress.testpress.databinding.RegisterActivityBinding |
There was a problem hiding this comment.
Couldn't find this file. Was this missed?
| verifyConfirmPassword() | ||
| } | ||
|
|
||
| private fun verifyUserName() { |
There was a problem hiding this comment.
The names aren't explaining what this method is doing. Verify is bit vague. How do you verify? What is the action?
Similarly with other methods.
harinath01
force-pushed
the
master
branch
4 times, most recently
from
c686873
to
f9b09e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes done
Guidelines