-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full Scala 3 derivation rework #285
Open
goshacodes
wants to merge
11
commits into
tethys-json:master
Choose a base branch
from
goshacodes:basic_scala3_derivation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Full Scala 3 derivation rework #285
goshacodes
wants to merge
11
commits into
tethys-json:master
from
goshacodes:basic_scala3_derivation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7931aa9
to
272b03f
Compare
goshacodes
commented
Apr 22, 2024
modules/core/src/main/scala-3/tethys/derivation/JsonWriterDerivation.scala
Outdated
Show resolved
Hide resolved
f456d50
to
a4b10d6
Compare
goshacodes
commented
Apr 22, 2024
modules/macro-derivation/src/test/scala-3/tethys/derivation/AutoWriterDerivationTest.scala
Outdated
Show resolved
Hide resolved
goshacodes
commented
Apr 22, 2024
modules/macro-derivation/src/test/scala-3/tethys/derivation/AutoWriterDerivationTest.scala
Outdated
Show resolved
Hide resolved
goshacodes
commented
Apr 22, 2024
modules/macro-derivation/src/test/scala-3/tethys/derivation/SemiautoWriterDerivationTest.scala
Outdated
Show resolved
Hide resolved
road21
reviewed
Apr 22, 2024
modules/core/src/main/scala-3/tethys/derivation/JsonReaderDerivation.scala
Outdated
Show resolved
Hide resolved
a4b10d6
to
c35f8d9
Compare
road21
reviewed
Apr 23, 2024
modules/core/src/main/scala-3/tethys/derivation/JsonReaderDerivation.scala
Outdated
Show resolved
Hide resolved
road21
reviewed
Apr 23, 2024
modules/core/src/main/scala-3/tethys/derivation/JsonWriterDerivation.scala
Outdated
Show resolved
Hide resolved
road21
reviewed
Apr 23, 2024
modules/core/src/main/scala-3/tethys/derivation/JsonWriterDerivation.scala
Outdated
Show resolved
Hide resolved
c35f8d9
to
9501a3c
Compare
road21
reviewed
Apr 23, 2024
modules/core/src/main/scala-3/tethys/derivation/JsonReaderDerivation.scala
Outdated
Show resolved
Hide resolved
ce26657
to
9501a3c
Compare
…_defauls fix collect defaults
road21
reviewed
Apr 23, 2024
f7d77eb
to
f246f50
Compare
f246f50
to
26b3c00
Compare
dos65
reviewed
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
В целом - топчик конечно.
Можешь еще по диффу пройтись посмотреть где нету \n
в конце файлов и добавить?
modules/core/src/main/scala-3/tethys/derivation/JsonReaderDerivation.scala
Outdated
Show resolved
Hide resolved
modules/core/src/test/scala-3/tethys/derivation/DerivationSpec.scala
Outdated
Show resolved
Hide resolved
dos65
reviewed
May 21, 2024
dos65
reviewed
May 21, 2024
7e57821
to
01f5942
Compare
65adcf7
to
127f2c6
Compare
c6b7731
to
af29911
Compare
681ac6d
to
1cc7527
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full derivation rework.
Fixed benchmark compilation.
Fixed Scala 3 reader performance